[Notifier] [BC BREAK] Change constructor signature for Mattermost and Esendex transport #39592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Dec 21, 2020
| @@ -68,18 +70,20 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| } | |||
|
|
|||
| $response = $this->client->request('POST', 'https://'.$this->getEndpoint().'/v1.0/messagedispatcher', [ | |||
| 'auth_basic' => $this->token, | |||
| 'auth_basic' => sprintf('%s:%s', $this->email, $this->password), | |||
There was a problem hiding this comment.
Before, this was assembled in the factory
OskarStark
commented
Dec 21, 2020
| @@ -44,7 +46,7 @@ public function __construct(string $token, string $accountReference, string $fro | |||
|
|
|||
| public function __toString(): string | |||
| { | |||
| return sprintf('esendex://%s', $this->getEndpoint()); | |||
| return sprintf('esendex://%s?accountreference=%s&from=%s', $this->getEndpoint(), $this->accountReference, $this->from); | |||
There was a problem hiding this comment.
I also updated the __toString() method to display accountreference and from, like in the other bridges
7f261cc to
10bd554
Compare
odolbeau
approved these changes
Dec 22, 2020
10bd554 to
03ea499
Compare
eac7509 to
4f4626c
Compare
|
Ready to merge from my side |
jderusse
reviewed
Dec 24, 2020
| 5.3.0 | ||
| ----- | ||
|
|
||
| * [BC BREAK] Changed signature of `MattermostTransport::__construct()` method from: |
6a24bc9 to
9a4d2bd
Compare
fabpot
approved these changes
Dec 29, 2020
… Esendex transport
|
Thank you @OskarStark. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #39428 (comment)
cc @odolbeau as you provided the bridge