Skip to content

[Notifier] [Mattermost] [BC BREAK] Change constructor signature #39593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Notifier] [Mattermost] [BC BREAK] Change constructor signature #39593

wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 5.x, but BC BREAK for experimental bridge
Bug fix? no
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR ---

Follows #39545

@OskarStark
[Notifier] [Mattermost] [BC BREAK] Change constructor signature
cd36f18 
| Q             | A
| ------------- | ---
| Branch?       | 5.x, but BC BREAK for experimental bridge
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Follows symfony#39545
@jderusse
Copy link
Member

please 🙏 use a single PR for all similar changes. This PR could have been done in #39592

@OskarStark
Copy link
Contributor Author

Moved code to #39592

@OskarStark OskarStark closed this Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break Notifier Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @jderusse @carsonbot