[Mailer] Add Support for email-validator v3 #39657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ben29
commented
Dec 29, 2020
•
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Tickets | Fix #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
Ticket: #39656 |
|
Can please check if other Components use this too and bump them also? Thanks |
derrabus
requested changes
Dec 29, 2020
| @@ -17,7 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=7.2.5", | |||
| "egulias/email-validator": "^2.1.10", | |||
| "egulias/email-validator": "^2.1.10|^3.0", | |||
There was a problem hiding this comment.
There are more places where this package needs to be bumped. Furthermore, we should try to patch the 4.4 branch instead.
There was a problem hiding this comment.
yes, on all the mailer components
There was a problem hiding this comment.
I would prefer 4.4, too
|
Closing in favor of #39685. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.