Skip to content

[PropertyAccess] use bitwise flags to configure when the property accessor should throw #39693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

[PropertyAccess] use bitwise flags to configure when the property accessor should throw #39693

merged 1 commit into from
Mar 9, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 3, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? yes
Tickets Fix #31126
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.x milestone Jan 3, 2021
@xabbuh xabbuh mentioned this pull request Jan 3, 2021
Closed
@xabbuh xabbuh force-pushed the issue-31126 branch 2 times, most recently from fba0380 to c718494 Compare January 3, 2021 11:54
@xabbuh xabbuh mentioned this pull request Jan 3, 2021
Merged
@xabbuh xabbuh force-pushed the issue-31126 branch 5 times, most recently from 088ad29 to b79cc73 Compare January 5, 2021 20:21
jderusse
jderusse reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to provide tests that cover the legacy paths

@xabbuh
Copy link
Member Author

xabbuh commented Jan 8, 2021

@jderusse tests added

chalasr
chalasr requested changes Mar 8, 2021
View reviewed changes
@xabbuh
Copy link
Member Author

xabbuh commented Mar 9, 2021

@chalasr fixed

@derrabus
Copy link
Member

derrabus commented Mar 9, 2021

Thank you Christian.

@derrabus derrabus merged commit fc016dd into symfony:5.x Mar 9, 2021
@xabbuh xabbuh deleted the issue-31126 branch March 9, 2021 09:45
@xabbuh xabbuh mentioned this pull request Mar 9, 2021
Merged
@OskarStark OskarStark mentioned this pull request Mar 9, 2021
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 9, 2021
@javiereguiluz
minor #15080 [PropertyAccess]  do not pass boolean constructor flags …
081b6ae 
…(xabbuh)

This PR was merged into the 5.3-dev branch.

Discussion
----------

[PropertyAccess]  do not pass boolean constructor flags

see symfony/symfony#39693

Commits
-------

a9cb63d [PropertyAccess] do not pass boolean constructor flags
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@jderusse jderusse jderusse left review comments

@derrabus derrabus derrabus approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Deprecation PropertyAccess Status: Reviewed
Projects
None yet
Milestone
5.4
8 participants
@xabbuh @derrabus @stof @jderusse @ogizanagi @chalasr @maxhelias @carsonbot