Skip to content

[PropertyAccess] use bitwise instead of boolean flags #15079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 9, 2021

@OskarStark
Copy link
Contributor

OskarStark commented Mar 9, 2021

The referenced ticket looks wrong 🤔

Did you mean symfony/symfony#39693 ?

@xabbuh
Copy link
Member Author

xabbuh commented Mar 9, 2021

The PR was intended this way. In symfony/symfony#32133 we introduced the ability to configure the magic methods behavior through a new bitwise flag with Symfony 5.2. We forgot to update this place while changing the one somewhere below in the document.

#15080 targets the 5.x branch to account for the additional bitwise flag introduced in symfony/symfony#39693 for 5.3.

@javiereguiluz javiereguiluz added this to the 5.2 milestone Mar 9, 2021
@javiereguiluz
Copy link
Member

Thank you Christian.

@javiereguiluz javiereguiluz merged commit c26e7a8 into symfony:5.2 Mar 9, 2021
@xabbuh xabbuh deleted the symfony-32133 branch March 10, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants