[Routing] don't decode nor double-encode already encoded slashes when generating URLs #39732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28d1905 to
284c0a5
Compare
0d1903c to
2c4597e
Compare
|
Now restricted to slashes only. |
2c4597e to
eaac18b
Compare
fabpot
approved these changes
Feb 5, 2021
|
Thank you @nicolas-grekas. |
Merged
|
Nice solution. I like it. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 8, 2022
…ters (usu) This PR was merged into the 6.1 branch. Discussion ---------- [Routing] Avoid double encoded slashes in query parameters | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #45114 | License | MIT | Doc PR | Similar feature as discussed in #13017 and implemented in #39732, however for query parameters and not for path parameters. This allows to manually encode slashes in query parameters before handing them over to `UrlGenerator` and avoids these slashes to be double encoded. Currently, it's not possible to generate an output with single encoded slashes in query parameters. See #45114 for further details. Commits ------- 1421298 [Routing] query parameters: don't decode nor double-encode already encoded slashes when generating URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #39339