-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form][Uid] Add UlidType and UuidType form types #39863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gemorroj
commented
Jan 16, 2021
Q | A |
---|---|
Branch? | 5.x |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | #36102 |
License | MIT |
Doc PR |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UuidToStringTransformer.php
Outdated
Show resolved
Hide resolved
1bd3ab0
to
066e8ce
Compare
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UuidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/UlidToStringTransformerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/UuidToStringTransformerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/UlidToStringTransformerTest.php
Outdated
Show resolved
Hide resolved
To make the CI pass we also need to add the Uid component to the |
@xabbuh I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done, thank you!
src/Symfony/Component/Form/Extension/Core/DataTransformer/UuidToStringTransformer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two failures remain.
src/Symfony/Component/Form/Tests/Extension/Core/Type/UlidTypeTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/Type/UuidTypeTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/DataTransformer/UlidToStringTransformer.php
Outdated
Show resolved
Hide resolved
@nicolas-grekas should we have separate |
I think I prefer to have them split into two types, but I don't have a strong opinion about this. |
My feeling has that having two distinct types makes it easier for users to discover how to use the form types (i.e. they can use them without the need to pass any options). |
Thank you @Gemorroj. |