Skip to content

[Form][Uid] Add UlidType and UuidType form types #39863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Conversation

Gemorroj
Copy link
Contributor

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets #36102
License MIT
Doc PR

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh xabbuh added this to the 5.x milestone Jan 17, 2021
@Gemorroj Gemorroj force-pushed the 5.x branch 2 times, most recently from 1bd3ab0 to 066e8ce Compare January 17, 2021 11:51
@xabbuh
Copy link
Member

xabbuh commented Jan 18, 2021

To make the CI pass we also need to add the Uid component to the require-dev section of the Form component. Can you please also add entries to the component's changelog?

@Gemorroj
Copy link
Contributor Author

@xabbuh I added "symfony/uid": "^5.1" to the require-dev section.

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, thank you!

@OskarStark OskarStark requested a review from derrabus January 18, 2021 19:45
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two failures remain.

@carsonbot carsonbot changed the title Add UlidType and UuidType form types [Form][Uid] Add UlidType and UuidType form types Jan 19, 2021
@stof
Copy link
Member

stof commented Jan 19, 2021

@nicolas-grekas should we have separate UlidType and UuidType or a single UidType ?

@nicolas-grekas
Copy link
Member

@nicolas-grekas should we have separate UlidType and UuidType or a single UidType ?

I think I prefer to have them split into two types, but I don't have a strong opinion about this.

@xabbuh
Copy link
Member

xabbuh commented Jan 19, 2021

My feeling has that having two distinct types makes it easier for users to discover how to use the form types (i.e. they can use them without the need to pass any options).

@xabbuh
Copy link
Member

xabbuh commented Jan 19, 2021

Thank you @Gemorroj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants