[Form] Remove hard dependency on symfony/intl #40298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Form/Extension/Core/Type/CurrencyType.php
Outdated
Show resolved
Hide resolved
|
The PR is updated and documentation is added. |
Nyholm
commented
Feb 24, 2021
| @@ -47,6 +48,10 @@ public function configureOptions(OptionsResolver $resolver) | |||
| $input = $options['input']; | |||
|
|
|||
| if ($options['intl']) { | |||
| if (!class_exists(Intl::class)) { | |||
| throw new LogicException(sprintf('The "symfony/intl" component is required to use "%s" with option "intl=true". Try running "composer require symfony/intl".', static::class)); | |||
There was a problem hiding this comment.
Note that this exception message is different.
nicolas-grekas
approved these changes
Feb 24, 2021
fabpot
approved these changes
Feb 25, 2021
|
Thank you @Nyholm. |
|
Thank you for merging |
Nyholm
added a commit
that referenced
this pull request
Feb 25, 2021
… (wouterj) This PR was merged into the 4.4 branch. Discussion ---------- [TwigBridge] Install symfony/intl to run tests on Travis | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | bi | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The hard dependency on `symfony/intl` was removed from the Form component in 5.3-dev (#40298). I suggest to add the explicit dev dependency on TwigBridge on 4.4 already. Commits ------- b297045 [TwigBridge] Install symfony/intl to run tests on Travis
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was voted down in 2018 (#29229) and will revert #29720 by @chalasr. I reopen it because the Form component is way less dependent on Intl component now.
Im hesitant if we should do this in 5.x or 6.0. If a user don't have
symfony/intlinstalled, they will get an error in runtime. That is something that speaks for doing it in 6.0.Could I get some opinions?
TODO
UPGRADE-x.x.md