[Form] Add note about Intl component #15026
Conversation
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Form] Remove hard dependency on symfony/intl | Q | A | ------------- | --- | Branch? | 5.x (or 6.0) | Bug fix? | | New feature? | no | Deprecations? | yes | Tickets | Fix #39596 | License | MIT | Doc PR | symfony/symfony-docs#15026 This was voted down in 2018 (#29229) and will revert #29720 by @chalasr. I reopen it because the Form component is way less dependent on Intl component now. Im hesitant if we should do this in 5.x or 6.0. If a user don't have `symfony/intl` installed, they will get an error in runtime. That is something that speaks for doing it in 6.0. Could I get some opinions? ### TODO - [x] Update `UPGRADE-x.x.md` Commits ------- f90d3ec [Form] Remove hard dependency on symfony/intl
|
Tobias, thanks for proposing these changes. However, in my opinion, we shouldn't merge this. Why? Because this feature has a perfect error message, so I don't think these docs are needed. If a user tries to use this and doesn't have the Intl component installed, they'll see this message: Although it's concise, it perfectly explains the problem and shows the solution, so I'd say that's enough. But let's wait for other opinions. Thanks! |
|
That is fair. But it should definitely be merged in 6.x |
Oh, my bad. I though this was a comment on a different PR. Im fine with not merging this PR. Im not sure what the praxis is in this scenario. I'll leave this open for a second opinion. |
|
I agree with @javiereguiluz 👍 It will mean less maintenance to be done on the documentation |
|
Okey. Thank you for the reviews and input. |
Documentation for PR symfony/symfony#40298
The Intl component is not a dependency of the form component anymore.