Skip to content

Speed up psalm by copy the cache #40310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Feb 25, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#...

Psalm is not using cache when generating a baseline. When a new baseline is generated, it will not use the "old" cache.

This PR copies the cache from the "generate baseline run".

@nicolas-grekas
Copy link
Member

It looks like the cache holds absolute paths so we cannot just copy it.
Instead, we should execute both scans in the same path.

@Nyholm
Copy link
Member Author

Nyholm commented Feb 25, 2021

Hm.. I cannot make this run quicker... Even with the same absolute path.

@nicolas-grekas nicolas-grekas mentioned this pull request Feb 25, 2021
@nicolas-grekas
Copy link
Member

It took time, but I did it in #40311 🎉

nicolas-grekas added a commit that referenced this pull request Feb 25, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

Speedup psalm

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

My try at #40310

Commits
-------

3fb74ab Speedup psalm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants