[HttpFoundation][HttpKernel] Rename master request to main request #40536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Mar 22, 2021
derrabus
commented
Mar 22, 2021
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Event/LazyResponseEvent.php
Outdated
Show resolved
Hide resolved
5011a93 to
1650c93
Compare
stof
reviewed
Mar 22, 2021
acb6700 to
b15deb0
Compare
|
As discussed with @nicolas-grekas via Slack: We decided to go with a soft deprecation of the constant for now. The reason is that it would get unreasonably hard to implement public function handle(Request $request, int $type = self::MASTER_REQUEST, bool $catch = true); |
b15deb0 to
1fc2a04
Compare
nicolas-grekas
approved these changes
Mar 22, 2021
Nyholm
approved these changes
Mar 22, 2021
|
Thank you for your work |
This was referenced Mar 22, 2021
Closed
derrabus
added a commit
that referenced
this pull request
Mar 22, 2021
…olm) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [WebLink] Remove symfony/http-foundation dependency | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #40536 | License | MIT | Doc PR | Both me and @derrabus overlooked this. Commits ------- 415c2a0 [WebLink] Remove symfony/http-foundation dependency
Merged
FabianSchmick
added a commit
to webfactory/slug-validation-bundle
that referenced
this pull request
Apr 15, 2024
Because of the introduction of main instead of master request symfony/symfony#40536
morawskim
added a commit
to morawskim/sf-utils
that referenced
this pull request
Apr 25, 2024
* Symfony 6 renamed master request to main request (symfony/symfony#40536) * PasswordEncoder not exists anymore, use PasswordHasher * Symfony 6 has own InMemory user provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's find a better term for "master request" because of the reasons described in #37509 (comment). This PR proposes the term main request instead.