Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Do I need to make any action for this

Issues that cannot be fixed automatically
in Commits list, a git rebase is needed to remove any merges
Merge remote-tracking branch 'origin/5.x' into 5.x

Never used before

Possible I need to do this one step https://symfony.com/doc/current/contributing/code/pull_requests.html#step-4-submit-your-pull-request

It took time, but here we go, this is in now. Thank you very much Vasilij.

Note: as a rule of thumb, commits should be squashed before merging (by the merger if not done by the contributor).

I know I already talked about this with with @jderusse and because the user changed its name in between it could not be squashed 😔

What should I read to reduce you work in the future? Maybe I can read something and make less work for you...

@StaffNowa instead of commiting additional changes in a separate commits, you can append your changes to the previous commit.

before:

$ git add src/Symfony/Notifier/Something.php
$ git commit -m"[Notifier] add something"
...
$ git add src/Symfony/Notifier/Tests/SomethingTest.php
$ git commit -m"[Notifier] add something tests"
$ git push

after:

$ git add src/Symfony/Notifier/Something.php
$ git commit -m"[Notifier] add something"
...
$ git add src/Symfony/Notifier/Tests/SomethingTest.php
$ git commit --amend --no-edit 
$ git push -f

now instead of having two commits, one with the message "[Notifier] add something" and the other with message "[Notifier] add something tests", you will end up with only 1 commit that has the message "[Notifier] add something"

Thanks. I will put for my remarks in the future ;)