[Notifier] Add MessageBird notifier bridge #40646

StaffNowa · 2021-03-31T05:06:15Z

Q	A
Branch?	5.x
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT
Doc PR	symfony/symfony-docs#15180
Recipe PR	symfony/recipes/pull/922

MessageBird notifier https://developers.messagebird.com/docs/conversations/send-messages-curl/

OskarStark

Please see my comments 👍

src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php

src/Symfony/Component/Notifier/Bridge/MessageBird/LICENSE

src/Symfony/Component/Notifier/Bridge/MessageBird/README.md

src/Symfony/Component/Notifier/Bridge/MessageBird/Tests/MessageBirdTransportFactoryTest.php

src/Symfony/Component/Notifier/Exception/UnsupportedSchemeException.php

OskarStark · 2021-03-31T12:07:55Z

It looks like your commiter email is not associated with your Github account 🤔

src/Symfony/Component/Notifier/Bridge/MessageBird/README.md

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransportFactory.php

OskarStark

LGTM 👍

StaffNowa · 2021-04-01T14:45:33Z

Added recipes for message bird #40646

StaffNowa · 2021-04-01T14:53:04Z

Added docs for message bird symfony/symfony-docs#15180

StaffNowa · 2021-04-02T05:46:02Z

MessageBird documentation issue solved 👍

src/Symfony/Component/Notifier/Bridge/MessageBird/composer.json

StaffNowa · 2021-04-02T07:52:24Z

@fabpot updated composer.json

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php

…, StaffNowa) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add LightSms notifier bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes  | Deprecations? | no  | License | MIT | Doc PR | symfony/symfony-docs/pull/15178 | Recipe PR | symfony/recipes#921 LightSms notifier https://github.com/D4DLab/lightsms-notifier Commits ------- 37c665e * LightSmsTransport.php - make fabbot happy 68a12fa * fix tests f1f83b9 * LightSmsTransport.php - use query string parameters 026dcd9 * LightSmsTransport.php - isset 2a9ac2d * LightSmsTransport.php - fix 4213564 * composer.json - fix Fabien comment from another pull request #40646 21e972a * coding standard bea5256 * type cast. On success lightsms return error code like string. On error return integer. 9b2e2d0 * type cast. On success lightsms return error code like string. On error return integer. 0d7488b * type cast. On success lightsms return error code like string. On error return integer. 9a832ef * LightSmsTransport.php - via mistake removed www which return (Closing direction to the user). Removed additional isset which in reality not needed. Added new method which allow to return "unknown error" and throw exception if not successfully 178d9c2 * pull request #40696 95e82f6 Update LightSmsTransport.php a197dee * LightSmsTransport.php - better to remove if we do not have it? 83d2598 * Coding Standard patch 1ff97e4 * LightSmsTransport.php - build signature and use http_build_query, timestamp int 1c993b7 * ERROR_CODES -> int * www. - bug * isset validate ['error'] 1b59a7d * LightSmsTransport.php - string param 58ac708 * LightSmsTransport.php - return back www (without will not work). Now fail tests b9f9ff8 * LightSmsTransport.php - tests fail 265f776 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 23a446a * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 08235e5 * LightSmsTransport.php - bug fix 80ef5ba * LightSmsTransport.php - Unable to send the SMS: Closing direction to the user 08b0729 Update LightSmsTransport.php 7180c1f Update LightSmsTransport.php f16b4d2 * phone changed to from 7f13dbf * sender changed to from e20ef1e * LightSmsTransport.php - change + to 00 b0e64b9 * LightSmsTransport.php - not ok throw exception fc13bb2 * LightSmsTransport.php - changed login for validation (the same like we have all places) 5d2e692 * LightSmsTransport.php - escape phone number 8620e82 * LightSmsTransport.php - move timestamp 66c34ba Update README.md 2e0e1d7 Update README.md 7b51e0d Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 079406e Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 0e41bc9 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php 3d0d79c Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php e0a68bd Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 1b073c2 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b0891be Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 49b4780 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b2e4638 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php c02dbbd Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 9f89014 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 5e54dfe * LightSmsTransport.php - quick fix for private constant. 3cbbc85 * HOST split into two parts 9e1809e * small changes febff46 Update src/Symfony/Component/Notifier/Bridge/LightSms/LICENSE 4a11b94 * github account author 728a3e2 * Transport.php - missing use ce41756 * notifier_transports.php - Coding Standard d1ccd46 * Attached file changes which are required to run the lightsms notifier a0fae7d * tests 15686c0 * LightSmsTransport.php - Coding Standard 2f65b92 * LightSmsTransport.php - Coding Standard 6792535 * composer.json - requirements bug fix 167f325 * LightSmsTransport.php - logic error be8f994 * LightSmsTransport.php - return type f2ba226 * LightSmsTransport.php - bug fix b075c0e * LightSms notifier

OskarStark · 2021-04-09T12:05:17Z

Please add CHANGELOG file

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php

src/Symfony/Component/Notifier/Bridge/MessageBird/Tests/MessageBirdTransportFactoryTest.php

src/Symfony/Component/Notifier/Bridge/MessageBird/Tests/MessageBirdTransportTest.php

OskarStark

LGTM 👍🏻✅

StaffNowa · 2021-04-09T14:17:32Z

Documentation too prepared symfony/symfony-docs#15180 :)

Nyholm

Thank you.

I have a few comments that I would like to see addressed.

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php

OskarStark · 2021-04-14T06:57:11Z

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php

+
+        if (201 !== $response->getStatusCode()) {
+            if (!isset($response->toArray(false)['errors'])) {
+                throw new TransportException('Unable to send the SMS.');


Too few arguments for Symfony\Component\Notifier\Exception\TransportException::__construct - expecting 2 but saw 1

looks like $response is missing

OskarStark · 2021-04-14T07:35:09Z

Please rebase, thanks

StaffNowa · 2021-04-14T08:21:41Z

@OskarStark rebase, but still get the same strange error

Run ./vendor/bin/psalm.phar --output-format=github --no-progress
Error: Too few arguments for Symfony\Component\Notifier\Exception\TransportException::__construct - expecting 2 but saw 1
Error: Process completed with exit code 2.

Nyholm

Thank you. Well done

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php

StaffNowa · 2021-04-14T08:51:00Z

Travis CI show errors @OskarStark

OskarStark · 2021-04-15T14:52:33Z

It took time, but here we go, this is in now. Thank you very much Vasilij.

This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] [MessageBird] add docs symfony/symfony#40646 Commits ------- ee5ee00 * notifier.rst - message bird

StaffNowa requested a review from OskarStark as a code owner March 31, 2021 05:06

carsonbot added Status: Needs Review Feature Notifier labels Mar 31, 2021

OskarStark requested changes Mar 31, 2021

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Mar 31, 2021

OskarStark reviewed Mar 31, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/README.md Outdated Show resolved Hide resolved

OskarStark reviewed Mar 31, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransportFactory.php Outdated Show resolved Hide resolved

OskarStark approved these changes Mar 31, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Mar 31, 2021

nicolas-grekas added this to the 5.x milestone Apr 1, 2021

StaffNowa mentioned this pull request Apr 1, 2021

[Notifier] MessageBird symfony/recipes#922

Merged

StaffNowa mentioned this pull request Apr 1, 2021

[Notifier] [MessageBird] add docs symfony/symfony-docs#15180

Merged

jderusse approved these changes Apr 2, 2021

View reviewed changes

fabpot requested changes Apr 2, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/composer.json Outdated Show resolved Hide resolved

carsonbot added Status: Needs Work and removed Status: Reviewed labels Apr 2, 2021

zairigimad approved these changes Apr 2, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php Show resolved Hide resolved

carsonbot added Status: Reviewed and removed Status: Needs Work labels Apr 2, 2021

StaffNowa requested a review from fabpot April 2, 2021 10:54

carsonbot added Status: Needs Review and removed Status: Reviewed labels Apr 2, 2021

OskarStark reviewed Apr 9, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php Outdated Show resolved Hide resolved

OskarStark reviewed Apr 9, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php Outdated Show resolved Hide resolved

OskarStark reviewed Apr 9, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/Tests/MessageBirdTransportFactoryTest.php Outdated Show resolved Hide resolved

OskarStark reviewed Apr 9, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/Tests/MessageBirdTransportTest.php Outdated Show resolved Hide resolved

symfony deleted a comment from StaffNowa Apr 9, 2021

OskarStark approved these changes Apr 9, 2021

View reviewed changes

OskarStark requested a review from Nyholm April 9, 2021 14:13

carsonbot added Status: Needs Review and removed Status: Reviewed labels Apr 9, 2021

Nyholm requested changes Apr 11, 2021

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Apr 11, 2021

OskarStark reviewed Apr 13, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php Outdated Show resolved Hide resolved

OskarStark added the Ready label Apr 13, 2021

OskarStark reviewed Apr 14, 2021

View reviewed changes

Nyholm approved these changes Apr 14, 2021

View reviewed changes

src/Symfony/Component/Notifier/Bridge/MessageBird/MessageBirdTransport.php Outdated Show resolved Hide resolved

carsonbot added Status: Reviewed and removed Status: Needs Work labels Apr 14, 2021

[Notifier] Add MessageBird notifier bridge

761817e

OskarStark merged commit 1ca10f5 into symfony:5.x Apr 15, 2021

StaffNowa deleted the message-bird branch April 15, 2021 15:38

fabpot mentioned this pull request Apr 18, 2021

Release v5.3.0-BETA1 #40853

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Notifier] Add MessageBird notifier bridge #40646

[Notifier] Add MessageBird notifier bridge #40646

StaffNowa commented Mar 31, 2021 •

edited

Loading

OskarStark left a comment

OskarStark commented Mar 31, 2021

OskarStark left a comment

StaffNowa commented Apr 1, 2021

StaffNowa commented Apr 1, 2021

StaffNowa commented Apr 2, 2021

StaffNowa commented Apr 2, 2021

OskarStark commented Apr 9, 2021

OskarStark left a comment

StaffNowa commented Apr 9, 2021

Nyholm left a comment

OskarStark Apr 14, 2021

OskarStark commented Apr 14, 2021

StaffNowa commented Apr 14, 2021

Nyholm left a comment

StaffNowa commented Apr 14, 2021

OskarStark commented Apr 15, 2021

[Notifier] Add MessageBird notifier bridge #40646

[Notifier] Add MessageBird notifier bridge #40646

Conversation

StaffNowa commented Mar 31, 2021 • edited Loading

OskarStark left a comment

Choose a reason for hiding this comment

OskarStark commented Mar 31, 2021

OskarStark left a comment

Choose a reason for hiding this comment

StaffNowa commented Apr 1, 2021

StaffNowa commented Apr 1, 2021

StaffNowa commented Apr 2, 2021

StaffNowa commented Apr 2, 2021

OskarStark commented Apr 9, 2021

OskarStark left a comment

Choose a reason for hiding this comment

StaffNowa commented Apr 9, 2021

Nyholm left a comment

Choose a reason for hiding this comment

OskarStark Apr 14, 2021

Choose a reason for hiding this comment

OskarStark commented Apr 14, 2021

StaffNowa commented Apr 14, 2021

Nyholm left a comment

Choose a reason for hiding this comment

StaffNowa commented Apr 14, 2021

OskarStark commented Apr 15, 2021

StaffNowa commented Mar 31, 2021 •

edited

Loading