Fixes #40633: Progress bar is broken when progress bar character is unicode. #40635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grasmash
commented
Mar 29, 2021
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #40633 |
| License | MIT |
|
Thank you for this PR. Could you add a test to this bug? |
jderusse
reviewed
Mar 31, 2021
| @@ -514,7 +514,7 @@ private static function initPlaceholderFormatters(): array | |||
| $display = str_repeat($bar->getBarCharacter(), $completeBars); | |||
| if ($completeBars < $bar->getBarWidth()) { | |||
| $emptyBars = $bar->getBarWidth() - $completeBars - Helper::strlenWithoutDecoration($output->getFormatter(), $bar->getProgressCharacter()); | |||
| $display .= $bar->getProgressCharacter().str_repeat($bar->getEmptyBarCharacter(), $emptyBars); | |||
There was a problem hiding this comment.
IMHO the issue is: $emptyBars should not be negative
There was a problem hiding this comment.
I agree the issue is deeper, there is a confusion in the component between "width" and "length".
Helper::strlen() deals with "width", and there is no helper to deal with "length", while it would be needed: a single simple-width character might be enough to replace a single double-width character. To be confirmed of course.
|
Maybe we should just revert the change that caused this? It seems like the issue extends beyond the scope of the progress bar. |
This was referenced Apr 3, 2021
fabpot
added a commit
that referenced
this pull request
Apr 8, 2021
…, grasmash) This PR was merged into the 5.2 branch. Discussion ---------- [Console] Add Helper::width() and Helper::length() | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Close #40697 Fix #40634, fix #40635 | License | MIT | Doc PR | This PR will add add a Helper::strwidth() and a Helper::strlength(). Same with with the Helper::strlenWithoutDecoration(). It does not deprecate anything. That is done in #40695 With this PR we dont have to revert the emoji issue (ie close #40697) FYI @grasmash, I used your tests from #40635 Commits ------- d9ea4c5 Add test. dc02ab3 [Console] Add Helper::strwidth() and Helper::strlength()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.