Skip to content

[Messenger] Add X-Ray trace header support to the SQS transport #40718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

WaylandAce
Copy link
Contributor

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

aws documentation: https://docs.aws.amazon.com/xray/latest/devguide/xray-services-sqs.html

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@WaylandAce WaylandAce force-pushed the sqs-xray-traceheader branch from e04e70f to 497a5a3 Compare April 7, 2021 11:29
@carsonbot
Copy link

Hey!

Haha, I was thinking of doing this exact same thing. =)

I think @starred-gijs has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Contributor

@starred-gijs starred-gijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks legit, but I'm not in a position that I can test this properly.

@WaylandAce WaylandAce force-pushed the sqs-xray-traceheader branch from 497a5a3 to 72e4a95 Compare April 9, 2021 19:09
@WaylandAce WaylandAce changed the title [Messenger] Added X-Ray trace header support to the SQS transport [Messenger] Add X-Ray trace header support to the SQS transport Apr 9, 2021
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request.
LGTM but have a small comment

don't forget to update the CHANGELOG

@WaylandAce WaylandAce force-pushed the sqs-xray-traceheader branch from 72e4a95 to 5fa7ff9 Compare April 9, 2021 21:55
@jderusse jderusse added this to the 5.x milestone Apr 10, 2021
@fabpot
Copy link
Member

fabpot commented Apr 13, 2021

Thank you @WaylandAce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants