-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Add X-Ray trace header support to the SQS transport #40718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
e04e70f
to
497a5a3
Compare
Hey! Haha, I was thinking of doing this exact same thing. =) I think @starred-gijs has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks legit, but I'm not in a position that I can test this properly.
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Outdated
Show resolved
Hide resolved
497a5a3
to
72e4a95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pull request.
LGTM but have a small comment
don't forget to update the CHANGELOG
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Outdated
Show resolved
Hide resolved
72e4a95
to
5fa7ff9
Compare
Thank you @WaylandAce. |
aws documentation: https://docs.aws.amazon.com/xray/latest/devguide/xray-services-sqs.html