[Notifier] LightSMS duplicated $errorCode variable fix #40735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Apr 8, 2021
| @@ -124,8 +124,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
|
|
|||
| $content = $response->toArray(false); | |||
|
|
|||
| if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) { | |||
| $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1; | |||
| if ($errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) { | |||
There was a problem hiding this comment.
Im sure this code is correct. But could we make it a bit more readable?
$errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1
if (0 !== $errorCode) {There was a problem hiding this comment.
@Nyholm good question :) For now do not have any suggestions how to make it more readable :(
There was a problem hiding this comment.
Yesterday, I created new method with if isset, but it is not good as understand @jderusse
There was a problem hiding this comment.
What do you think about my suggestion?
There was a problem hiding this comment.
👍 for Tobias' suggestion. That's also what ##40733 (comment) suggested to do
There was a problem hiding this comment.
we both suggested
$errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;
if (0 !== $code) {
you implemented
if ($errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) {
Nyholm
approved these changes
Apr 8, 2021
chalasr
approved these changes
Apr 8, 2021
|
Thanks Vasilij. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicated variable $errorCode.
Many thanks for:
@OskarStark, @jderusse and special thanks for @chalasr for fast rebase course at night :)))