[Security] Deprecate using UsageTrackingTokenStorage outside the request-response cycle #40785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Apr 12, 2021
src/Symfony/Component/Security/Core/Authentication/Token/Storage/UsageTrackingTokenStorage.php
Show resolved
Hide resolved
6ecdbf7 to
53aa87b
Compare
jderusse
approved these changes
Apr 12, 2021
derrabus
reviewed
Apr 12, 2021
UPGRADE-5.3.md
Outdated
| @@ -102,6 +102,9 @@ Routing | |||
| Security | |||
| -------- | |||
|
|
|||
| * Deprecate using `UsageTrackingTokenStorage` with tracking enabled without a main request. Use the untracking token | |||
There was a problem hiding this comment.
Suggested change
| * Deprecate using `UsageTrackingTokenStorage` with tracking enabled without a main request. Use the untracking token | |
| * Deprecate using `UsageTrackingTokenStorage` with tracking enabled without a main request. Use the untracked token |
fabpot
approved these changes
Apr 13, 2021
53aa87b to
7452476
Compare
|
Thank you @wouterj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you get an "There is currently no session available" exception when using the
security.token_storageservice outside the main request-response cycle (e.g. in akernel.terminatelistener). This PR deprecates such usage and requires developers to update their definitions to explicitly usesecurity.untracked_token_storageinstead.A different solution would be to silently disable tracking in these cases, but I think that might create some unnecessary technical debt.