[Config] Add command to dump ConfigBuilders #40803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b6ab01 to
ec518e1
Compare
|
cant we dump along when the container is dumped? Im not sure one should ever call this command 🤔 IIUC configuration classes are already resource tracked, thus reloaded on change. |
|
Since we strive to reduce the list of default commands, I'm not sure we need this command. Cache warmers are enough to me. |
|
Thank you both for your input. Im closing this PR in favour of #40804 |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 14, 2021
…ilder (Nyholm) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Config][FrameworkBundle] Add CacheWarmer for ConfigBuilder | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | | Tickets | | License | MIT | Doc PR | Make sure ConfigBuilder exists before you write your first line of config. This is similar to #40803 Commits ------- c1d6c0e [Config][FrameworkBundle] Add CacheWarmer for ConfigBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a command
config:dump-buildersthat you can force to dump ConfigBuilders.We can discuss if this is needed if we have a cache warmer. Ie, then the ConfigBuilders will be generated on
cache:warmup. See #40804