[Config][FrameworkBundle] Add CacheWarmer for ConfigBuilder #40804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php
Outdated
Show resolved
Hide resolved
Nyholm
commented
Apr 13, 2021
| $this->dumpExtension($extension, $generator); | ||
| } catch (\Throwable $e) { | ||
| if ($this->logger) { | ||
| $this->logger->warning('Failed to generate ConfigBuilder for extension {extensionClass).', ['exception' => $e, 'extensionClass' => \get_class($extension)]); |
There was a problem hiding this comment.
If a (bundle) extension is using some syntax not supported by the generator builder, we dont want an exception when warming the cache. The user may not even be using the ConfigBuilder for that extension.
There was a problem hiding this comment.
s/{extensionClass)/{extensionClass}
src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
Outdated
Show resolved
Hide resolved
yceruto
reviewed
Apr 13, 2021
src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php
Outdated
Show resolved
Hide resolved
OskarStark
added a commit
that referenced
this pull request
Apr 14, 2021
…ebugContainerTrait::getContainerBuilder() (Nyholm) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] Add argument KernelInterface to BuildDebugContainerTrait::getContainerBuilder() | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This comes from a suggestion by `@yceruto` #40804 (comment) This change will make the trait usable outside the `Command` namespace. I did not find a better namespace to move the trait to though.. This patch will help #40804 The trait is internal so the change is okey. Commits ------- 0e9652a [FrameworkBundle] Add argument KernelInterface to BuildDebugContainerTrait::getContainerBuilder()
nicolas-grekas
approved these changes
Apr 14, 2021
OskarStark
approved these changes
Apr 14, 2021
src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
Outdated
Show resolved
Hide resolved
yceruto
approved these changes
Apr 14, 2021
56cc9e6 to
c1d6c0e
Compare
|
Thank you @Nyholm. |
|
Awesome. :) |
Merged
| if ($extension instanceof ConfigurationInterface) { | ||
| $configuration = $extension; | ||
| } elseif ($extension instanceof ConfigurationExtensionInterface) { | ||
| $configuration = $extension->getConfiguration([], $this->getContainerBuilder($this->kernel)); |
There was a problem hiding this comment.
$extension->getConfiguration() can return null, while $generator->build() doesn't accept null. See doctrine/DoctrineFixturesBundle#349.
There was a problem hiding this comment.
Thanks for testing prereleases! This will be fixed by #40859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure ConfigBuilder exists before you write your first line of config.
This is similar to #40803