Skip to content

[Translation] Added PoEditor Provider #40926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

[Translation] Added PoEditor Provider #40926

merged 1 commit into from
May 10, 2021

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Apr 23, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#15310

To follow up on #38475, this PR adds PoEditor Provider.

The todo list to make it ready is:

  • Apply recent changes that have been made on ProviderInterface and TranslatorBagInterface (we removed the all() and getDomains() method from TranslatorBagInterface)
  • Add PoEditorProvider to src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php file
  • Add PoEditor case to Symfony\Component\Translation\Exception\UnsupportedSchemeException
  • Write integration tests by mocking HTTP Responses

The major part of the remaining work concerns tests, I will make it done before the beginning of May.

@carsonbot
Copy link

Please note that you need squash your commits before this PR can be merged. The maintainer can also squash the commits for you, but then you need to “Allow edits from maintainer” (there is a checkbox in the sidebar of the PR).

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas added this to the 5.3 milestone Apr 23, 2021
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch 4 times, most recently from 363ff30 to 3fbeb16 Compare April 23, 2021 15:25
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch 2 times, most recently from cd050d5 to 0ab9d41 Compare April 26, 2021 20:18
@welcoMattic
Copy link
Member Author

Package / Verify check fails now, it will be fixed as soon as #40928 will be merged.

@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch 4 times, most recently from a50035f to 32e25a0 Compare April 27, 2021 14:43
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch 2 times, most recently from 4952323 to 63b9b51 Compare April 27, 2021 15:58
@welcoMattic
Copy link
Member Author

It ready for me for a review.
cc @OskarStark @Nyholm @nicolas-grekas

@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch 4 times, most recently from 700b7f3 to 3d39d82 Compare May 1, 2021 16:29
@welcoMattic welcoMattic mentioned this pull request May 5, 2021
Merged
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch from b13f0d4 to 4a199d1 Compare May 6, 2021 20:38
@nicolas-grekas nicolas-grekas requested a review from stof May 7, 2021 15:06
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch from 4a199d1 to 25bab11 Compare May 7, 2021 22:03
@fabpot
Copy link
Member

fabpot commented May 9, 2021

Tests seem broken.

@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch from 25bab11 to 7568332 Compare May 9, 2021 16:13
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch 2 times, most recently from 865cb70 to 3b1c532 Compare May 10, 2021 09:54
@welcoMattic welcoMattic force-pushed the feature/poeditor-provider branch from 3b1c532 to 240ac22 Compare May 10, 2021 09:59
welcoMattic
welcoMattic commented May 10, 2021
View reviewed changes
src/Symfony/Component/Translation/CHANGELOG.md
@@ -5,6 +5,8 @@ CHANGELOG
---

* Add `translation:pull` and `translation:push` commands to manage translations with third-party providers
* Add `TranslatorBagInterface::getCatalogues` method
* Add support to load XLIFF string in `XliffFileLoader`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot I've added those missing changes here

@welcoMattic
Copy link
Member Author

Last comments have been addressed, branch has been rebased

@fabpot
Copy link
Member

fabpot commented May 10, 2021

Thank you @welcoMattic.

@fabpot fabpot merged commit af19b6b into symfony:5.x May 10, 2021
@welcoMattic welcoMattic deleted the feature/poeditor-provider branch May 10, 2021 10:13
@fabpot fabpot mentioned this pull request May 12, 2021
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request May 19, 2021
@javiereguiluz
minor #15310 [Translation] Introduce Translation Providers (welcoMattic)
fb1fa0d 
This PR was submitted for the 5.4 branch but it was squashed and merged into the 5.3 branch instead.

Discussion
----------

[Translation] Introduce Translation Providers

Docs for symfony/symfony#38475, symfony/symfony#40926, symfony/symfony#40927, and symfony/symfony#40947

Ready for first review, but I'm not sure that I've written documentation in the right and all required places.

ATM, Translation Providers Bridges packages doesn't exists, so Flex recipes are not created yet.

Commits
-------

943a63f [Translation] Introduce Translation Providers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Ready Status: Reviewed Translation
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
6 participants
@welcoMattic @carsonbot @fabpot @nicolas-grekas @stof @OskarStark