[Translation] Introduce Translation Providers #15310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
485ffbd to
5d3ef38
Compare
This was referenced May 6, 2021
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 10, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- [Translation] Added PoEditor Provider | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#15310 To follow up on #38475, this PR adds [PoEditor](https://poeditor.com/) Provider. The todo list to make it ready is: - [x] Apply recent changes that have been made on `ProviderInterface` and `TranslatorBagInterface` (we removed the `all()` and `getDomains()` method from TranslatorBagInterface) - [x] Add PoEditorProvider to `src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php` file - [x] Add PoEditor case to `Symfony\Component\Translation\Exception\UnsupportedSchemeException` - [x] Write integration tests by mocking HTTP Responses The major part of the remaining work concerns tests, I will make it done before the beginning of May. Commits ------- 240ac22 Added PoEditor Provider
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 10, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- [Translation] Added Lokalise Provider | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#15310 To follow up on #38475, this PR adds [Lokalise](https://lokalise.com/) Provider. The todo list to make it ready is: - [x] Apply recent changes that have been made on `ProviderInterface` and `TranslatorBagInterface` (we removed the `all()` and `getDomains()` method from TranslatorBagInterface) - [x] Add LokaliseProvider to `src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php` file - [x] Add Lokalise case to `Symfony\Component\Translation\Exception\UnsupportedSchemeException` - [x] Move `LokaliseProvider` and `LokaliseProviderFactory` from `Symfony\Component\Translation\Bridge\Lokalise\Provider` to `Symfony\Component\Translation\Bridge\Lokalise` namespace - [x] Write integration tests by mocking HTTP Responses The major part of the remaining work concerns tests, I will make it done before the beginning of May. Commits ------- 022d828 Added Lokalise Provider
06cfb5c to
943a63f
Compare
|
Mathieu, thanks a lot for this fantastic feature and for providing the docs for it. We finally merged this PR and we'll talk about this feature in the next "New in Symfony 5.3" blog post 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for symfony/symfony#38475, symfony/symfony#40926, symfony/symfony#40927, and symfony/symfony#40947
Ready for first review, but I'm not sure that I've written documentation in the right and all required places.
ATM, Translation Providers Bridges packages doesn't exists, so Flex recipes are not created yet.