[Messenger] Removed deprecated code #41319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a10dfa to
b4b48c1
Compare
derrabus
requested changes
May 20, 2021
derrabus
reviewed
May 21, 2021
src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
Outdated
Show resolved
Hide resolved
derrabus
reviewed
May 21, 2021
src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
Outdated
Show resolved
Hide resolved
1f46605 to
39d0234
Compare
|
The PR is updated and rebased. |
|
Status: needs review |
chalasr
reviewed
May 23, 2021
src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
added a commit
that referenced
this pull request
May 27, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Messenger] remove legacy code paths | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Should make tests green. (and missed in #41319) Commits ------- 6d65673 [Messenger] remove legacy code paths
|
Rebase needed! |
8d103bb to
d328c1f
Compare
Nyholm
commented
Jul 11, 2021
2781c25 to
49d5ef7
Compare
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
8a2ccba to
3b70e2d
Compare
|
Thank you @Nyholm. |
|
Thank you for merging |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 11, 2021
This PR was squashed before being merged into the 5.2 branch. Discussion ---------- [Messenger] Fixed BC layer for RedeliveryStamp | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Related to #41319 (comment) | License | MIT | Doc PR | n/a In Symfony 6, the second argument to RedeliveryStamp's constructor will be a DateTimeInterface. We should already allow people to instantiate this object with the Symfony 6 way. Commits ------- ac3c4d7 [Messenger] Fixed BC layer for RedeliveryStamp
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 23, 2021
…t` config option (andrew-demb) This PR was merged into the 6.0 branch. Discussion ---------- [Messenger] Remove mention to unsupported `prefetch_count` config option <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> `prefetch_count` was removed in symfony/symfony#41319 Commits ------- b8602c4 Remove mention to unsupported `prefetch_count` config option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove deprecated code from Messenger.
TODO