Skip to content

[Messenger] Fixed BC layer for RedeliveryStamp #42059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2021
Merged

[Messenger] Fixed BC layer for RedeliveryStamp #42059

merged 1 commit into from
Jul 11, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 11, 2021 •
edited
Loading

Q A
Branch? 5.2
Bug fix? no
New feature? no
Deprecations? yes
Tickets Related to #41319 (comment)
License MIT
Doc PR n/a

In Symfony 6, the second argument to RedeliveryStamp's constructor will be a DateTimeInterface. We should already allow people to instantiate this object with the Symfony 6 way.

@Nyholm Nyholm requested a review from sroze as a code owner July 11, 2021 17:13
@carsonbot carsonbot added this to the 5.2 milestone Jul 11, 2021
@Nyholm Nyholm mentioned this pull request Jul 11, 2021
Merged
1 task
@Nyholm Nyholm force-pushed the 5.2-redelivery-stamp branch from bfbf3ed to 7ae55e0 Compare July 11, 2021 17:58
@nicolas-grekas
Copy link
Member

Thank you @Nyholm.

@nicolas-grekas nicolas-grekas merged commit 1864689 into symfony:5.2 Jul 11, 2021
This was referenced Jul 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Messenger Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @nicolas-grekas @carsonbot