[Validator] Remove deprecated code #41392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jschaedl
commented
May 23, 2021
•
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR |
- remove deprecated code
- fix tests
- update CHANGELOG
a88aa15 to
4fac42d
Compare
jschaedl
commented
May 23, 2021
|
Please rebase to restart tests 🙏 |
src/Symfony/Component/Validator/Constraints/LengthValidator.php
Outdated
Show resolved
Hide resolved
4fac42d to
ad616cc
Compare
|
Ready for final review. :-) fabbot failures seem to be false positives. |
derrabus
approved these changes
May 28, 2021
|
See #41440 for the fabbot issues. 🙂 |
nicolas-grekas
approved these changes
May 31, 2021
276312f to
e44ac6b
Compare
|
Thank you @jschaedl. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.