Skip to content

[Validator] Fix CS in constraint tests #41440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2021
Merged

[Validator] Fix CS in constraint tests #41440

merged 1 commit into from
May 29, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone May 28, 2021
@derrabus derrabus mentioned this pull request May 28, 2021
Merged
3 tasks
@nicolas-grekas
Copy link
Member

fix 4.4 right?

@derrabus
Copy link
Member Author

On 4.4, these tests don't exist. On 5.2, all of these are wrapped in eval() statements because of the named argument calls. So we only need to fix that on 6.0.

@derrabus derrabus force-pushed the cs/constraint-tests branch from 9e960b5 to 59727d3 Compare May 29, 2021 20:14
@derrabus derrabus merged commit 28111c4 into symfony:6.0 May 29, 2021
@derrabus derrabus deleted the cs/constraint-tests branch May 29, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @nicolas-grekas @javiereguiluz @OskarStark @carsonbot