[Asset] Don't pass null to strpos() #41559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jun 6, 2021
| Q | A |
|---|---|
| Branch? | 5.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Part of #41552 |
| License | MIT |
| Doc PR | N/A |
Signed-off-by: Alexander M. Turek <me@derrabus.de>
xabbuh
reviewed
Jun 6, 2021
src/Symfony/Component/Asset/VersionStrategy/JsonManifestVersionStrategy.php
Show resolved
Hide resolved
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2021
…haljusiega) This PR was merged into the 5.3 branch. Discussion ---------- [Asset][Security] Fixed leftover deprecations PHP 8.1 | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Part of #41552, leftover #41559 | License | MIT | Doc PR | ~ Found during testing **PHP 8.1** and Symfony **5.4.0-BETA1** 1. src/Symfony/Component/Asset/VersionStrategy/JsonManifestVersionStrategy.php  Looks like #41559 didn't solve the deprecation completely. 2. src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php  `Request::getRequestFormat()` and `Request::getContentType()` may return nulls. Commits ------- 86934e6 fixed leftover deprecations PHP 8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.