Skip to content

[Asset][Security] Fixed leftover deprecations PHP 8.1 #43948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021
Merged

[Asset][Security] Fixed leftover deprecations PHP 8.1 #43948

merged 1 commit into from
Nov 6, 2021

Conversation

michaljusiega
Copy link
Contributor

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Part of #41552, leftover #41559
License MIT
Doc PR ~

Found during testing PHP 8.1 and Symfony 5.4.0-BETA1

  1. src/Symfony/Component/Asset/VersionStrategy/JsonManifestVersionStrategy.php
    obraz

Looks like #41559 didn't solve the deprecation completely.

  1. src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php
    obraz

Request::getRequestFormat() and Request::getContentType() may return nulls.

@carsonbot carsonbot added this to the 5.3 milestone Nov 5, 2021
@carsonbot carsonbot changed the title [Security][Asset] Fixed leftover deprecations PHP 8.1 [Asset][Security] Fixed leftover deprecations PHP 8.1 Nov 5, 2021
@nicolas-grekas
Copy link
Member

Thank you @michaljusiega.

@nicolas-grekas nicolas-grekas merged commit 07a891f into symfony:5.3 Nov 6, 2021
@michaljusiega michaljusiega deleted the fix-php81-deprecation-on-strpos-nullable-haystack-parameter branch November 6, 2021 12:58
This was referenced Nov 14, 2021
@fabpot fabpot mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants