[PasswordHasher] Fix missing PasswordHasherAwareInterface allowed type #41678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14f0818 to
c1d40d3
Compare
chalasr
commented
Jun 11, 2021
| @@ -26,7 +25,7 @@ interface PasswordHasherFactoryInterface | |||
| /** | |||
| * Returns the password hasher to use for the given user. | |||
| * | |||
| * @param PasswordAuthenticatedUserInterface|UserInterface|string $user A PasswordAuthenticatedUserInterface/UserInterface instance or a class name | |||
| * @param PasswordHasherAwareInterface|PasswordAuthenticatedUserInterface|string $user A PasswordAuthenticatedUserInterface/PasswordHasherAwareInterface instance or a class name | |||
There was a problem hiding this comment.
UserInterface is the legacy type here - which we don't document usually
nicolas-grekas
approved these changes
Jun 11, 2021
src/Symfony/Component/PasswordHasher/Hasher/PasswordHasherFactoryInterface.php
Outdated
Show resolved
Hide resolved
c1d40d3 to
8d3bea5
Compare
chalasr
added a commit
that referenced
this pull request
Jun 11, 2021
…e from UserPasswordHasherInterface API (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- [PasswordHasher] Remove PasswordHasherAwareInterface type from UserPasswordHasherInterface API | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no (not yet released) | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by `@stof` in #41640 (comment), the methods of this interface should not handle user classes/instances that are not implementing `PasswordAuthenticatedUserInterface`. This reverts that part from #41678 (not released yet). Commits ------- 596ba78 [PasswordHasher] Remove PasswordHasherAwareInterface from UserPasswordHasherInterface API
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also backports test changes from #41640