[SecurityBundle] Hide security toolbar if no firewall matched #41874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jun 27, 2021
94noni
approved these changes
Jun 27, 2021
|
I think that this change is a good idea. I'm unsure about merging it as a bugfix, though. |
|
I agree with @derrabus, this should target 5.4 instead (I would have been ok-ish if this was a "behavior" that changed in 5.3, but here, the behavior has been consistent since a long time). |
f7b278a to
a3a4bcf
Compare
a3a4bcf to
a2e77cd
Compare
|
rebase needed |
a2e77cd to
29706ea
Compare
maxhelias
approved these changes
Jun 30, 2021
29706ea to
75590aa
Compare
fabpot
approved these changes
Jul 2, 2021
|
Thank you @wouterj. |
xabbuh
reviewed
Jul 2, 2021
src/Symfony/Bundle/SecurityBundle/Resources/views/Collector/security.html.twig
Show resolved
Hide resolved
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @pavol-tk, we currently show a red Security block in the toolbar if no firewall matched. I think we should instead leave the block out of the toolbar, just like we do with all other elements if there is no data for that request.
cc @javiereguiluz as you're the best in these UX like decisions :)