[Contracts] add return types and bump to v3 #42088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 13, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | #42058 |
| License | MIT |
| Doc PR | - |
bd68e60 to
2891252
Compare
470b02d to
c200b51
Compare
|
PR ready! |
stof
reviewed
Jul 13, 2021
dddcc52 to
cb120f4
Compare
I agree, and I did the same for psr/cache, sticking to 3.0. |
Tobion
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
LGTM but don't the test failures indicate a problem?
PHP Fatal error: Declaration of Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\FormLoginBundle\Controller\LoginController::getSubscribedServices() must be compatible with Symfony\Contracts\Service\ServiceSubscriberInterface::getSubscribedServices(): array in /home/runner/work/symfony/symfony/src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/FormLoginBundle/Controller/LoginController.php on line 66
derrabus
approved these changes
Jul 13, 2021
cb120f4 to
44b1a7a
Compare
|
Thank you Nicolas. |
Merged
derrabus
added a commit
that referenced
this pull request
Dec 20, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [Contracts] Allow psr/container 1.1 again | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT The only difference between psr/container 1.1 and 2.0 is one additional return type on the `ContainerInterface::has()` method, see php-fig/container@1.1.2...2.0.2 This means that if a package is compatible with 2.0 already (== all implementations already have that return type), it remains compatible with 1.1. However, in #42088 we changed the composer.json of our service-contracts package and replaced `^1.1` with `^2.0`, dropping support for 1.1 although there was no need to do so. I'm migrating a larger application to Symfony 7 at the moment which also consumes various Laminas packages. Due to Laminas still being stuck on psr/container 1.1, I cannot upgrade to service-contracts 3 which in turn blocks my Symfony 7 upgrade. It would smoothen the upgrade path a lot for me, if we released a service-contracts 3.x that allows the installation of psr/container 1.1 again. Commits ------- 80d34d0 Allow psr/container 1.1 again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.