[Contracts] Allow psr/container 1.1 again #53150
Conversation
|
related: |
|
For 6.3? |
|
Thank you very much for the quick approval. 🚀 |
The change does not appear in the split repository: https://github.com/symfony/service-contracts/branches/all Did we target the wrong branch or is there something wrong with the splitter? |
|
I think we might need to merge up |
did that, but that doesn't seem to be enough (or the sync takes longer than I expected) |
|
The change does appear on the contracts repository however: symfony/contracts@bd6978f. But apparently, it does not travel further down to the service-contracts package from there. 😕 |
|
Problem solved: symfony/service-contracts@11bbf19 🥳 |
This PR was merged into the 6.4 branch. Discussion ---------- [Contracts] Allow psr/container 1.1 again | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT This a follow up from #53150 (initially incorrectly submitted against symfony/contracts#6). Commits ------- df47df5 Allow psr/container 1.1 again
The only difference between psr/container 1.1 and 2.0 is one additional return type on the
ContainerInterface::has()method, see php-fig/container@1.1.2...2.0.2This means that if a package is compatible with 2.0 already (== all implementations already have that return type), it remains compatible with 1.1. However, in #42088 we changed the composer.json of our service-contracts package and replaced
^1.1with^2.0, dropping support for 1.1 although there was no need to do so.I'm migrating a larger application to Symfony 7 at the moment which also consumes various Laminas packages. Due to Laminas still being stuck on psr/container 1.1, I cannot upgrade to service-contracts 3 which in turn blocks my Symfony 7 upgrade.
It would smoothen the upgrade path a lot for me, if we released a service-contracts 3.x that allows the installation of psr/container 1.1 again.