[Security] add return types #42513
Merged
[Security] add return types #42513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71cd16c to
1af45e1
Compare
|
If I'm correct, these changes are all automated (correct me if I'm wrong). In that case, I would appreciate it if this could be merged after #41613, to avoid merge conflicts (I'm currently working on the last 5.4 PR that is blocking the merge). |
|
Works for me, I'll rebase after. |
1af45e1 to
8f951bc
Compare
|
By the way fabbot not happy 😃😊 |
3ad6d62 to
077a238
Compare
nicolas-grekas
commented
Aug 18, 2021
There was a problem hiding this comment.
/cc @wouterj here are some comments for you I guess (+ review welcome of course :) )
src/Symfony/Component/Security/Core/Authentication/AuthenticationTrustResolverInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/NullToken.php
Outdated
Show resolved
Hide resolved
chalasr
reviewed
Aug 18, 2021
src/Symfony/Component/Security/Core/Authentication/AuthenticationTrustResolverInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/NullToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/TokenInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Exception/AuthenticationException.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authentication/Token/NullToken.php
Outdated
Show resolved
Hide resolved
wouterj
reviewed
Aug 18, 2021
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Show resolved
Hide resolved
src/Symfony/Component/Security/Csrf/CsrfTokenManagerInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Csrf/CsrfTokenManagerInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Csrf/CsrfTokenManagerInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Csrf/TokenGenerator/TokenGeneratorInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Csrf/TokenStorage/TokenStorageInterface.php
Outdated
Show resolved
Hide resolved
077a238 to
873b1ee
Compare
d003dfa to
b71fa54
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 20, 2021
…ekas) This PR was merged into the 5.4 branch. Discussion ---------- [Security] fix restrictive return annotation | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - See #42513 (comment) for rationale. Commits ------- 974e4ba [Security] fix restrictive return annotation
symfony-splitter
pushed a commit
to symfony/security-http
that referenced
this pull request
Aug 20, 2021
…ekas) This PR was merged into the 5.4 branch. Discussion ---------- [Security] fix restrictive return annotation | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - See symfony/symfony#42513 (comment) for rationale. Commits ------- 974e4ba23d [Security] fix restrictive return annotation
b71fa54 to
ea1af77
Compare
ea1af77 to
8871327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #42496
Not all possible return types are patched for the attached components, to save breaking BC cross-components, for now at least.