[Console] add is_enabled option to console.command tag #42679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Aug 22, 2021
3 tasks
chalasr
approved these changes
Aug 22, 2021
|
is |
@ro0NL I don't think so |
|
What's the purpose vs not putting the tag on the service? |
|
@chr-hertel Any feedback regarding @nicolas-grekas's question? |
|
Sorry, yes, we wrote about this and decided to go a different way. changed the implementation of #42580 to remove the service definition instead of using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until now it was not possible to override the
$isEnabled = trueof theLazyCommandwas originally part of #42580