[Mailer] [Sendgrid] Fix test #43053
Merged
[Mailer] [Sendgrid] Fix test #43053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Sep 16, 2021
|
I'm fine with bumping. However, we could get around it by skipping the new tests if |
|
We could indeed. I tend to prefer bumping over adding a skip condition here, but both work for me. Let me know about your preference |
73c946b to
3d77313
Compare
|
PR updated, now skips the problematic test based on class existence. |
|
Yes, I think that's better. We bump the dependency on the 6.0 branch anyway and can remove the skip condition there. |
|
I think, the commit message and PR title deserve an update. Apart from that, let's merge to make the CI green again. |
3d77313 to
375e95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
low-deps build is broken after #43018 because it uses symfony/mailer 4.4.x while
TagHeaderis 5.x only.