Skip to content

[Messenger] Use TransportMessageIdStamp in InMemoryTransport allows retrying #43096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexndlm
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 4.4 milestone Sep 19, 2021
@carsonbot
Copy link

Hey!

I think @tyx has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@alexndlm alexndlm requested a review from jderusse September 22, 2021 16:21
@okwinza
Copy link
Contributor

okwinza commented Sep 24, 2021

This seems to add some additional logic and thus feels more like a feature to me and should target 5.4 branch.
Are you sure it's a bug?

@alexndlm
Copy link
Contributor Author

This seems to add some additional logic and thus feels more like a feature to me and should target 5.4 branch.
Are you sure it's a bug?

For now, it is not possible to resend the same message with InMemory transport. I think it is a bug.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except from a minor comment, this makes ways more sense than the previous logic!

@nicolas-grekas nicolas-grekas force-pushed the feature/allow-retrying-for-in-memory-transport branch 2 times, most recently from a9feb76 to 858236d Compare October 30, 2021 13:21
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated your patch to my suggestion

@nicolas-grekas nicolas-grekas force-pushed the feature/allow-retrying-for-in-memory-transport branch 3 times, most recently from 7642e86 to 9ae6ae7 Compare October 30, 2021 13:36
@nicolas-grekas nicolas-grekas force-pushed the feature/allow-retrying-for-in-memory-transport branch from 9ae6ae7 to 609b07d Compare October 30, 2021 13:41
@nicolas-grekas
Copy link
Member

Thank you @alexndlm.

@nicolas-grekas nicolas-grekas merged commit 27d8daf into symfony:4.4 Oct 30, 2021
This was referenced Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants