-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Use TransportMessageIdStamp
in InMemoryTransport
allows retrying
#43096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messenger] Use TransportMessageIdStamp
in InMemoryTransport
allows retrying
#43096
Conversation
alexndlm
commented
Sep 19, 2021
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
License | MIT |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Hey! I think @tyx has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/Messenger/Transport/InMemoryTransport.php
Outdated
Show resolved
Hide resolved
This seems to add some additional logic and thus feels more like a feature to me and should target 5.4 branch. |
For now, it is not possible to resend the same message with InMemory transport. I think it is a bug. |
src/Symfony/Component/Messenger/Transport/InMemoryTransport.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except from a minor comment, this makes ways more sense than the previous logic!
a9feb76
to
858236d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated your patch to my suggestion
7642e86
to
9ae6ae7
Compare
9ae6ae7
to
609b07d
Compare
Thank you @alexndlm. |