Allow for missing whitelines. #4339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to rebase your branch. github tells us it cannot be merged automatically |
| if ($newLine) { | ||
| $output .= "\n"; | ||
| } | ||
| else { |
fabpot
added a commit
that referenced
this pull request
May 19, 2012
Commits ------- fb6cf3e Allow for missing whitelines. Discussion ---------- Allow for missing whitelines. The Gettext specification allows for 'whitespace is optional' between message string. For this to work PoFileLoader needs to save found messages on more places while processing. Thus a new method is introduced. For the tests to work PoFileDumper was changed slightly to only emit white-lines when necessary. I added more documentation from the GNU gettext documentation to make the code more understandable. When [[BUG] PoFileLoader pluralhandling uses interval instead of index.](#4336) this patch needs some small rework. (this is part of [[WIP]: Allow Drupal to use Translate component)](#4249) --------------------------------------------------------------------------- by travisbot at 2012-05-19T12:44:19Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374295) (merged fb6cf3e into 58b9245). --------------------------------------------------------------------------- by stof at 2012-05-19T13:19:29Z you need to rebase your branch. github tells us it cannot be merged automatically
|
@clemens-tolboom using substr at the end should be better, on each loop you have and cond and a variable assign, (you also and a concat OP) |
|
@stealth35 ic ... what should one do with a (this) closed PR? |
|
@clemens-tolboom Just create a new one and reference this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gettext specification allows for 'whitespace is optional' between message string.
For this to work PoFileLoader needs to save found messages on more places while processing. Thus a new method is introduced.
For the tests to work PoFileDumper was changed slightly to only emit white-lines when necessary.
I added more documentation from the GNU gettext documentation to make the code more understandable.
When [BUG] PoFileLoader pluralhandling uses interval instead of index. this patch needs some small rework.
(this is part of [WIP]: Allow Drupal to use Translate component)