[HttpFoundation] Remove possibility to pass null as $requestIp in IpUtils #43550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 18, 2021
|
Thank you @W0rma. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2023
…onTrait` where it is not used (GromNaN) This PR was merged into the 6.4 branch. Discussion ---------- [DoctrineBridge][HttpFoundation] Remove `ExpectDeprecationTrait` where it is not used | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | n/a This unused code has been left since 6.0 by #43100 and #43550. The PR targets 6.4 because this is not a bug, but minor code cleanup. Commits ------- 9317cbd Remove ExpectDeprecationTrait where it is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the code which was deprecated in #43411