Skip to content

[Messenger] Autoconfigurable attributes #43588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

[Messenger] Autoconfigurable attributes #43588

merged 1 commit into from
Oct 25, 2021

Conversation

alirezamirsepassi
Copy link
Contributor

@alirezamirsepassi alirezamirsepassi commented Oct 19, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #41106
License MIT
Doc PR symfony/symfony-docs#15990

@carsonbot carsonbot added this to the 5.4 milestone Oct 19, 2021
@ro0NL
Copy link
Contributor

ro0NL commented Oct 19, 2021

ref #41202 :)

@alirezamirsepassi
Copy link
Contributor Author

ref #41202 :)

Oh sorry, didn't see that! :)

I suppose #41202 PR could not be merged right away because of lacking test and configurable attributes since May 13.
I would really appreciate it if @nicolas-grekas and @fabpot could help here.

nicolas-grekas
nicolas-grekas approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some minor tweaks

@nicolas-grekas
Copy link
Member

Oh, please also add a changelog entry in the component

@nicolas-grekas nicolas-grekas mentioned this pull request Oct 20, 2021
Closed
@nicolas-grekas
Copy link
Member

And can you please prepare a PR for the doc?

@alirezamirsepassi alirezamirsepassi mentioned this pull request Oct 22, 2021
Merged
@Tobion Tobion force-pushed the messenger/attributes branch from f8ec53a to f27e594 Compare October 25, 2021 19:54
@Tobion
Copy link
Contributor

Tobion commented Oct 25, 2021

Thanks for your work on this new feature!

@Tobion Tobion merged commit c3e4bf9 into symfony:5.4 Oct 25, 2021
@Tobion
Copy link
Contributor

Tobion commented Oct 25, 2021 •
edited
Loading

There was a test failure for low deps

Symfony\Component\Messenger\Tests\DependencyInjection\MessengerPassTest::testTaggedMessageHandler
Error: Call to undefined method Symfony\Component\DependencyInjection\ContainerBuilder::registerAttributeForAutoconfiguration()

that I've fixed by raising the DI dependency for messenger.

@Tobion Tobion mentioned this pull request Oct 25, 2021
Closed
@Tobion
Copy link
Contributor

Tobion commented Oct 25, 2021

I have also opened #43705 as a follow-up.

@alirezamirsepassi
Copy link
Contributor Author

Great!
Thank you @Tobion

This was referenced Nov 5, 2021
Merged
Merged
wouterj added a commit to symfony/symfony-docs that referenced this pull request Jan 19, 2022
@wouterj
feature #15990 [Messenger] Autoconfigurable attributes (alirezamirsep…
01be48d 
…assi)

This PR was merged into the 5.4 branch.

Discussion
----------

[Messenger] Autoconfigurable attributes

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `5.x` for features of unreleased versions).

-->
symfony/symfony#43588

Commits
-------

7069075 [#15990] Minor changes
fdd8b86 [Messenger] Autoconfigurable attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Tobion Tobion Tobion approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Messenger] Message attributes
5 participants
@alirezamirsepassi @ro0NL @nicolas-grekas @Tobion @carsonbot