[Messenger] Autoconfigurable attributes #15990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
added a commit
to symfony/symfony
that referenced
this pull request
Oct 25, 2021
…assi) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Messenger] Autoconfigurable attributes | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #41106 | License | MIT | Doc PR | symfony/symfony-docs#15990 Commits ------- f27e594 [Messenger] Autoconfigurable attributes
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
Oct 25, 2021
…assi) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Messenger] Autoconfigurable attributes | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #41106 | License | MIT | Doc PR | symfony/symfony-docs#15990 Commits ------- f27e594bad [Messenger] Autoconfigurable attributes
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Oct 25, 2021
…assi) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Messenger] Autoconfigurable attributes | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #41106 | License | MIT | Doc PR | symfony/symfony-docs#15990 Commits ------- f27e594bad [Messenger] Autoconfigurable attributes
|
Any update on this PR ? @nicolas-grekas |
94noni
approved these changes
Dec 28, 2021
|
Maybe just document that attributes requires php v8 (the feature is on v5.4 thus v8 is not mandatory like v6) |
messenger.rst
Outdated
| message interface):: | ||
| create a class using :class:`Symfony\\Component\\Messenger\\Attribute\\AsMessageHandler` | ||
| attribute which has an ``__invoke()`` method that's type-hinted with the | ||
| message class (or a message interface) or you can create a class without the attribute, by implementing |
There was a problem hiding this comment.
I'd remove the mention of the interface
|
Thank you @alirezamirsepassi for providing docs with your code contributions. I've applied all suggestions made by @nicolas-grekas and added some directives indicating this is a new feature. I did however merge it in 5.4, as that's where this was introduced (which is similar to other PHP attribute we've documented for 5.3/5.4). |
wouterj
added a commit
that referenced
this pull request
Jan 19, 2022
* 5.4: [#15990] Minor changes [Messenger] Autoconfigurable attributes
wouterj
added a commit
that referenced
this pull request
Jan 19, 2022
* 6.0: Removed 5.4 versionadded [#15990] Minor changes [Messenger] Autoconfigurable attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#43588