Skip to content

[VarDumper] Fix Cannot instantiate abstract class on (...) #43652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

event15
Copy link
Contributor

@event15 event15 commented Oct 22, 2021

Fix for Cannot instantiate abstract class on (...) in ExceptionCaster in VarDumper.

Q A
Branch? 4.4 (and olders?)
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #27921
License MIT

In this issue #27921 @nicolas-grekas said that this affects very old versions - even 2.8. I created a branch from 4.4 according to the CONTRIBBUTING guide.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@event15 event15 changed the base branch from 5.4 to 4.4 October 22, 2021 11:24
@event15
Copy link
Contributor Author

event15 commented Oct 22, 2021

I close this PR and replace with: #43655

@event15 event15 closed this Oct 22, 2021
@event15 event15 deleted the ticket_27921 branch October 22, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VarDumper] Exception Caster Crashes on Twig Template Inspection
3 participants