[VarDumper] Fix dumping twig templates found in exceptions #43655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Oct 22, 2021
|
I noticed that appveyor reports a mismatch between I don't quite understand the problem with failing tests on version 7.4 high-deps. There is a suggestion in the documentation that it may be BC. On the other hand, I see that merged PRs are also failing this steps (for example: https://github.com/symfony/symfony/actions/runs/1367057090 was merged) - so I don't know what it depends on. |
Cannot instantiate abstract class on (...) in `Exce…
src/Symfony/Component/VarDumper/Tests/Caster/ExceptionCasterTest.php
Outdated
Show resolved
Hide resolved
4799586 to
0229e5c
Compare
|
Thank you @event15 |
|
@nicolas-grekas great! Thanks so much for your patience and help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
Cannot instantiate abstract class on (...)inExceptionCasterin VarDumper.In this issue #27921 @nicolas-grekas said that this affects very old versions - even 2.8. I created a branch from 4.4 according to the CONTRIBBUTING guide.