Skip to content

[Security][SecurityBundle] Add types to private properties #43872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

[Security][SecurityBundle] Add types to private properties #43872

merged 1 commit into from
Nov 3, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 1, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone Nov 1, 2021
@carsonbot carsonbot changed the title Add types to private properties [Security][SecurityBundle] Add types to private properties Nov 1, 2021
@nicolas-grekas
Copy link
Member

psalm has a point, not sure how to fix that. wdyt?

@derrabus
Copy link
Member Author

derrabus commented Nov 2, 2021

I'll look into that later today and also do the backports then.

@derrabus derrabus force-pushed the types/security-properties branch from a21b81c to c8612a5 Compare November 2, 2021 20:20
@derrabus
[Security] Add types to private properties
dbe423d 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the types/security-properties branch from c8612a5 to dbe423d Compare November 2, 2021 20:31
@fabpot
Copy link
Member

fabpot commented Nov 3, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 3f66185 into symfony:6.0 Nov 3, 2021
@derrabus derrabus deleted the types/security-properties branch November 3, 2021 07:51
@derrabus derrabus mentioned this pull request Nov 3, 2021
Merged
fabpot added a commit that referenced this pull request Nov 3, 2021
@fabpot
minor #43899 [Security][SecurityBundle] Backport type fixes (derrabus)
aa68efc 
This PR was merged into the 5.4 branch.

Discussion
----------

[Security][SecurityBundle] Backport type fixes

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Backports from #43872
| License       | MIT
| Doc PR        | N/A

Commits
-------

8ac471b [Security] Backport type fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Security SecurityBundle Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @nicolas-grekas @fabpot @carsonbot