Skip to content

[Form] Add inputmode attribute on NumberType #45101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2022
Merged

[Form] Add inputmode attribute on NumberType #45101

merged 1 commit into from
Jan 22, 2022

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Jan 21, 2022 •
edited
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #45099
License MIT
Doc PR symfony/symfony-docs#...

Quick add of inputmode attribute on NumberType, let's discuss about this:

  • Should it be the default?
  • Should we add a way to not add the attribute?

Thank you @GromNaN for the issue, I had this idea in mind for a long time 😉

@carsonbot carsonbot added this to the 6.1 milestone Jan 21, 2022
@welcoMattic welcoMattic requested review from GromNaN and removed request for xabbuh and yceruto January 21, 2022 08:36
@stof
Copy link
Member

stof commented Jan 21, 2022 •
edited
Loading

This PR is the same thing than #34986 that has been reverted in #36869
-1 from me for the same reason than 2 years ago.

@welcoMattic welcoMattic changed the title [Form] Add inputmode attribute on some FormType [Form] Add inputmode attribute on NumberType Jan 21, 2022
@welcoMattic welcoMattic force-pushed the feature/inputmode branch 3 times, most recently from 3d5d808 to 394e518 Compare January 21, 2022 10:13
@welcoMattic
Copy link
Member Author

Updated after discussion in #45099. It brings inputmode attribute for NumberType only

GromNaN
GromNaN approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this feature proposal.

@fabpot
Copy link
Member

fabpot commented Jan 22, 2022

Thank you @welcoMattic.

@fabpot fabpot mentioned this pull request Jan 22, 2022
Closed
@fabpot fabpot merged commit 1ebb5d9 into symfony:6.1 Jan 22, 2022
@welcoMattic welcoMattic deleted the feature/inputmode branch January 23, 2022 11:29
@welcoMattic welcoMattic mentioned this pull request Jan 23, 2022
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 24, 2022
@javiereguiluz
minor #16436 [Form] Add inputmode doc for NumberType (welcoMattic)
3cef48b 
This PR was merged into the 6.1 branch.

Discussion
----------

[Form] Add inputmode doc for NumberType

Ref #16433

The code is already merged in symfony/symfony#45101

Commits
-------

f913d04 Add inputmode doc for NumberType
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[Form] Add inputmode=email/numeric/search/tel to form types
6 participants
@welcoMattic @stof @fabpot @GromNaN @yceruto @carsonbot