Skip to content

[Notifier] Add Sendberry notifier bridge #45195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022
Merged

[Notifier] Add Sendberry notifier bridge #45195

merged 1 commit into from
Mar 26, 2022

Conversation

StaffNowa
Copy link
Contributor

@StaffNowa StaffNowa commented Jan 26, 2022

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR #16452
Recipe PR symfony/recipes#1054

Sendberry notifier https://www.sendberry.com/

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks for your contribution.

Please add a docs and recipes PR 👍

@StaffNowa
Copy link
Contributor Author

Some comments, thanks for your contribution.

Please add a docs and recipes PR +1

Thanks for your time. I updated my code and prepared recipes and docs.

@StaffNowa
Copy link
Contributor Author

StaffNowa commented Jan 27, 2022

@welcoMattic you are right. We do not need to validate "from" at all. They validate ourselves. We catch this with

if (isset($responseArr['status']) && 'ok' !== $responseArr['status']) {
    throw new TransportException(sprintf("Unable to send the SMS. \n%s\n", implode("\n", $responseArr['message'])), $response);
}

image

@StaffNowa
Copy link
Contributor Author

@nicolas-grekas thanks. Made small changes

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know anyone at Sendberry that you back the bridge? Would you like to reach them about that?

@StaffNowa
Copy link
Contributor Author

StaffNowa commented Feb 21, 2022

Do you know anyone at Sendberry that you back the bridge? Would you like to reach them about that?

I am just found them on the internet. I can try to send the link to your blog post :)
Found in my Facebook 2021-08-30, I tried to contact "Sendberry - Mobile Marketing," but response nothing.

@fabpot
Copy link
Member

fabpot commented Mar 26, 2022

Thank you @StaffNowa.

@fabpot fabpot merged commit 68a2ba2 into symfony:6.1 Mar 26, 2022
@fabpot fabpot mentioned this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants