Skip to content

[Translation] Add the possibilty to export xliff translation with the .xliff suffix #45421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

DanielBadura
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Like the YamlFileDumper now the XliffFileDumper has the extension as an parameter. This enables the user to export xliff translation files with the suffix .xlf and .xliff. This is needed for example for the translation provider Lokalise and the GitLab integration for this provider.

@carsonbot carsonbot added this to the 6.1 milestone Feb 14, 2022
@DanielBadura DanielBadura force-pushed the add-export-as-xliff branch 3 times, most recently from f2d7f04 to 87b69dc Compare February 14, 2022 15:23
@carsonbot
Copy link

Hey!

I think @natewiebe13 has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@natewiebe13
Copy link
Contributor

natewiebe13 commented Feb 16, 2022

What about adding a configuration so you can set the extension from there? or maybe an argument for the command?

@DanielBadura
Copy link
Contributor Author

The command get's the allowed format types from the list of dumper services AFAIK. I dont understand the part with the configuration in the xml. If I generate a new file, there is no existing file and therefore no place to configure it, right?

@natewiebe13
Copy link
Contributor

Sorry, I had a typo. I haven't yet looked into how the command retrieves available extensions, but this makes sense. Unfortunate that it already uses xliff for the service name. Since there's really no difference in terms of content, it might be worth looking into changing how this works to be more flexible. For example passing more than one file extension.

@DanielBadura
Copy link
Contributor Author

The proposed solution is the same like how it was handled with yml and yaml the only difference there is that the service names matches with suffix :D

But i think the name is just a minor thing, so i hope someone has a good naming proposal :)

@DanielBadura
Copy link
Contributor Author

Failing CI seems unrelated

@fabpot fabpot force-pushed the add-export-as-xliff branch from 4ca1606 to 08c4bc5 Compare February 25, 2022 07:40
@fabpot
Copy link
Member

fabpot commented Feb 25, 2022

Thank you @DanielBadura.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants