-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Translation] Add the possibilty to export xliff translation with the .xliff suffix #45421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f2d7f04
to
87b69dc
Compare
Hey! I think @natewiebe13 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Bundle/FrameworkBundle/Resources/config/translation.php
Outdated
Show resolved
Hide resolved
What about adding a configuration so you can set the extension from there? or maybe an argument for the command? |
The command get's the allowed format types from the list of dumper services AFAIK. I dont understand the part with the configuration in the xml. If I generate a new file, there is no existing file and therefore no place to configure it, right? |
Sorry, I had a typo. I haven't yet looked into how the command retrieves available extensions, but this makes sense. Unfortunate that it already uses xliff for the service name. Since there's really no difference in terms of content, it might be worth looking into changing how this works to be more flexible. For example passing more than one file extension. |
The proposed solution is the same like how it was handled with But i think the name is just a minor thing, so i hope someone has a good naming proposal :) |
Failing CI seems unrelated |
4ca1606
to
08c4bc5
Compare
Thank you @DanielBadura. |
Like the
YamlFileDumper
now theXliffFileDumper
has the extension as an parameter. This enables the user to export xliff translation files with the suffix.xlf
and.xliff
. This is needed for example for the translation provider Lokalise and the GitLab integration for this provider.