Skip to content

Improve testsuite #45792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2022
Merged

Improve testsuite #45792

merged 1 commit into from
Mar 22, 2022

Conversation

blueForman
Copy link
Contributor

@blueForman blueForman commented Mar 19, 2022 •
edited
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#...

Work done:
Integration tests are excluded from unit testsuite because:

  • they are already tested in integration testsuite
  • they rely on enviroment and because of that they become skipped
  • they generate a huge list of false skipped tests in unit testsuite

Fixed Predis Client initialization in CombinedStoreTest because array_combine(['host', 'port'], explode(':', getenv('REDIS_HOST')) + [1 => null]) always results in localhost: as redis host which fails in host resolving

@blueForman blueForman requested a review from jderusse as a code owner March 19, 2022 12:17
@carsonbot carsonbot added this to the 6.1 milestone Mar 19, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. can you please target 4.4?

@blueForman blueForman changed the base branch from 6.1 to 4.4 March 20, 2022 18:01
@blueForman
Copy link
Contributor Author

thanks. can you please target 4.4?

@nicolas-grekas done

@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 4.4 Mar 21, 2022
@nicolas-grekas
Copy link
Member

Thank you @blueForman.

@nicolas-grekas nicolas-grekas merged commit c83b2d6 into symfony:4.4 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@blueForman @carsonbot @nicolas-grekas @stof